feat(zim): add zim uploader in content manager#751
Conversation
|
i've only tested a single file upload of a ~800MB file and it kinda just worked and showed up in the Information Library and content manager. needs more testing and it put in text about the file size limit being 80GB but i think thats probably not going to work well for an upload unless its on the same machine maybe. my knowledge base ingestion is broken, i think same issue as #718 |
|
Nice work — genuinely useful feature, and the shape is right. Security is clean (path traversal check, sanitized filename, atomic Two small things I'd tighten before merge:
Re: testing — your KB ingestion issue is almost certainly the same For the testing matrix before merge, I'd want to see:
Happy to run any of those on NOMAD3 once you feel it's ready for external testing. |
4f92e53 to
adb33fb
Compare
|
Addressed comments. |
adb33fb to
3e147fe
Compare
|
ok tested/fixed a few things, should be mostly good now, see bug info below.
bug, not sure how to handle this one: |
3e147fe to
15fc57c
Compare
|
resolved conflict w/force-push. did a quick test by deleting and then re-uploading the same zim file |
|
Go ahead and build in the inability to upload anything when there are any current downloads happening. I think that's a good remediation to any issues. |
15fc57c to
b9448a0
Compare
|
@chriscrosstalk , done. i just tested it. i ran a download in Content Explorer and while that happened i repeatedly uploaded the ~300MB and then the 2GB wikipedia and it didn't care it let me keep switching between the two on the side. but even if you were to do an upload/download of same name, then the latest one will get to be the "winner" ill say. |
b9448a0 to
6271bee
Compare
|
Thanks @hestela, this is still a feature we want. Two things before it can move forward:
Once it's rebased and reconciled we'll give it a full review. |
6271bee to
a7318ff
Compare
adds a collapsible file uploader to accept zim file uploads into kiwix.
a7318ff to
e955dc1
Compare
|
@chriscrosstalk , addressed your comments and rebased. tested by uploading a few different wikipedia tiers. and that logic still works (where you can switch tiers by uploading a different zim) |
adds a collapsible file uploader to accept zim file uploads into kiwix.